Skip to content
This repository has been archived by the owner on May 19, 2024. It is now read-only.

[WEAV-137] 인증 필터, 인가 인터셉터 구현 #46

Merged
merged 7 commits into from
Feb 2, 2024
Merged

[WEAV-137] 인증 필터, 인가 인터셉터 구현 #46

merged 7 commits into from
Feb 2, 2024

Conversation

waterfogSW
Copy link
Member

@waterfogSW waterfogSW commented Feb 2, 2024 •
edited
Loading

구현사항

  • :support:security 모듈
    • SecurityContextHolder 구현
      • 스레드 로컬로 필터에서 인증된 사용자 인증정보를 요청내에서 전역적으로 접근가능하게 만들어둠)
    • JwtAuthenticationFilter
      • 토큰이 있으면 파싱해 ContextHolder에 인증 정보 저장,
      • 요청 완료 이후 context clear -> thread 재사용으로 인해 사용자 정보가 다른 요청에 공유되지 않도록 구현
    • AuthorizationFilter
      • @Secured 어노테이션이 붙은 핸들러는 필터를 통해 SecurityContextHolder에 저장된 사용자 정보가 있어야만 접근 가능
      • 해당 정보가 없을 경우 HTTP 400 - exceptionCode=API-003 (unauthorized) 응답

논의 사항

  • 예외코드들은 400으로 통일하되, exceptionCode로 구분하는것이 좋을것 같아요
  • Spring Security 는 러닝커브가 있기도 하고 너무 불필요하게 많은 기능을 제공하는것 같아서 배제시켰어요

@waterfogSW waterfogSW added the feat New feature or request label Feb 2, 2024
@waterfogSW waterfogSW self-assigned this Feb 2, 2024
@waterfogSW waterfogSW requested a review from dojinyou as a code owner February 2, 2024 06:59
@dojinyou dojinyou self-requested a review February 2, 2024 07:16
dojinyou
dojinyou reviewed Feb 2, 2024
View reviewed changes
Copy link
Collaborator

@dojinyou dojinyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

잘못 승인 눌러서 코멘트로 변경

@waterfogSW waterfogSW requested a review from dojinyou February 2, 2024 07:34
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 2, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
89.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@waterfogSW waterfogSW merged commit 2385552 into main Feb 2, 2024
3 checks passed
@waterfogSW waterfogSW deleted the feat/WEAV-137 branch February 2, 2024 07:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dojinyou dojinyou dojinyou approved these changes

Assignees

@waterfogSW waterfogSW

Labels
feat New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@waterfogSW @dojinyou